Add note that LLDB changes should be cherry-picked to swift/master#32133
Add note that LLDB changes should be cherry-picked to swift/master#32133martinboehme merged 5 commits intomasterfrom
swift/master#32133Conversation
|
@swift-ci Please smoke test |
|
LGTM, but I would like us to get a review from someone working on Swift-enabled LLDB like @fredriss. |
|
@swift-ci Please smoke test Linux |
|
I don't think this reflects how anyone is working today. We work mainly on
The forwarding to swift/master will disappear later in the release cycle. The rule of thumb we use for LLDB is:
It would be nice to be able to live on master-next, but we're not there yet. |
Thanks for the input! Just to confirm: This means that the current doc (without my PR) is also already wrong, as it says "Changes that depend on Swift (this only applies to LLDB): new commits go to You're saying this should instead read "New commits go to Correct? |
In essence, yes. But it's a little more nuanced than this. There's nothing really wrong with committing first to The really important thing is that commits should go to both |
Thanks, got it! I've changed the wording in the doc accordingly -- WDYT? All of this is very relevant to me right now, BTW, since I'm preparing a (Swift-dependent) change for LLDB (not surprisingly, this is what triggered me to make this change to the doc). I've currently got it on |
|
@swift-ci Please smoke test |
|
This looks good with one last tweak (sorry!). The current release branches are not named |
No problem. How does this look now? |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
This was previously missing -- the doc mentioned only
swift/master-nextand release branches.